Skip to content

Use relative visibility when noting sealed trait to reduce false positive #143431

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Use relative visibility when noting sealed trait to reduce false positive #143431

wants to merge 2 commits into from
+48 −5

Conversation

xizheyin
Copy link
Contributor

@xizheyin xizheyin commented Jul 4, 2025 •
edited by rustbot
Loading

Fixes #143392

I used relative visibility instead of just determining if it's public or not.

r? compiler

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jul 4, 2025
@xizheyin xizheyin changed the title 143392 Use relative visibility when noting sealed trait to reduce false positive Jul 4, 2025
compiler-errors
compiler-errors reviewed Jul 4, 2025
View reviewed changes
Copy link
Member

@compiler-errors compiler-errors left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This code need a bunch of cleanup.

compiler-errors
compiler-errors requested changes Jul 4, 2025
View reviewed changes
@compiler-errors compiler-errors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 4, 2025
@xizheyin
Copy link
Contributor Author

xizheyin commented Jul 5, 2025

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@compiler-errors compiler-errors compiler-errors requested changes

Assignees

@compiler-errors compiler-errors

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Diagnostic incorrectly identifying sealed traits
4 participants
@xizheyin @compiler-errors @petrochenkov @rustbot